Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document extraResources field in tenant helm chart #1739

Merged
merged 4 commits into from
Sep 5, 2023
Merged

document extraResources field in tenant helm chart #1739

merged 4 commits into from
Sep 5, 2023

Conversation

pjuarezd
Copy link
Member

No description provided.

@pjuarezd
document extraResources
2619e5d 
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
@pjuarezd pjuarezd changed the title document extraResources document extraResources field in tenant helm chart Aug 24, 2023
@pjuarezd pjuarezd mentioned this pull request Aug 24, 2023
Closed
4 tasks
jiuker
jiuker previously approved these changes Aug 24, 2023
View reviewed changes
shtripat
shtripat previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check the shellcheck warning.

@pjuarezd pjuarezd requested a review from feorlen August 24, 2023 05:54
@pjuarezd
Copy link
Member Author

@feorlen, we will wait for your review before merge this PR

feorlen
feorlen reviewed Aug 24, 2023
View reviewed changes
helm/tenant/values.yaml Outdated Show resolved Hide resolved
feorlen
feorlen reviewed Aug 24, 2023
View reviewed changes
helm/tenant/values.yaml Outdated Show resolved Hide resolved
feorlen
feorlen reviewed Aug 24, 2023
View reviewed changes
helm/tenant/values.yaml Outdated Show resolved Hide resolved
feorlen
feorlen previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
Suggested a small edit to the comment explaining what this is for

@pjuarezd @feorlen
Update helm/tenant/values.yaml
8029a0f 
Co-authored-by: Andrea Longo <feorlen@users.noreply.github.com>
@pjuarezd pjuarezd dismissed stale reviews from feorlen, shtripat, and jiuker via 8029a0f August 24, 2023 14:14
pjuarezd and others added 2 commits August 24, 2023 08:14
@pjuarezd @feorlen
Update helm/tenant/values.yaml
b90d649 
Co-authored-by: Andrea Longo <feorlen@users.noreply.github.com>
@pjuarezd @feorlen
Update helm/tenant/values.yaml
0578f1d 
Co-authored-by: Andrea Longo <feorlen@users.noreply.github.com>
feorlen
feorlen approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@feorlen feorlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@harshavardhana harshavardhana merged commit b2f4b2f into minio:master Sep 5, 2023
@djwfyi djwfyi mentioned this pull request Sep 6, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@feorlen feorlen feorlen approved these changes

@jiuker jiuker jiuker left review comments

@shtripat shtripat shtripat left review comments

Assignees

@harshavardhana harshavardhana

@pjuarezd pjuarezd

@cniackz cniackz

@shtripat shtripat

@jiuker jiuker

@dvaldivia dvaldivia

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pjuarezd @feorlen @harshavardhana @shtripat @jiuker @cniackz @dvaldivia